nodejs/node

FormData, Response, Request, and Headers have incorrect property descriptors

Open

Aperta il 20 ott 2022

Vedi su GitHub
 (7 commenti) (1 reazione) (0 assegnatari)JavaScript (117.218 star) (35.535 fork)batch import
confirmed-bughelp wanted

Descrizione

Version

v18.11.0

Platform

Microsoft Windows NT 10.0.19043.0 x64

Subsystem

No response

What steps will reproduce the bug?

The property descriptors should match such that this test succeeds:


for (const global of [
  'Headers',
  'Request',
  'Response',
  'FormData'
]) {
  const desc = Object.getOwnPropertyDescriptor(globalThis, global)
  
  assert.notStrictEqual(desc, undefined)
  assert.deepStrictEqual(desc.value, globalThis[global])
  assert.ok(desc.writable)
  assert.ok(!desc.enumerable)
  assert.ok(desc.configurable)
}

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

the tests from above pass

What do you see instead?

the descriptors are inconsistent with other environments

Additional information

No response

Guida contributor

Tech stack
javascriptnodejs
Dominio
apibackend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
JavaScript property descriptorsNode.js internals
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
50
Direzione di ricerca
Investigate the property descriptors for Headers, Request, Response, and FormData in Node.js. The correct descriptors should have writable: true, enumerable: false, configurable: true. Check the source code in lib/internal/webapi/ or similar files where these globals are defined. Compare with browser implementations to ensure consistency. The fix would involve setting the property descriptor appropriately, possibly using Object.defineProperty.