nodejs/node

Run tests with OPENSSL_CONF set to embedded openssl.cnf

Open

Aperta il 15 nov 2018

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)JavaScript (117.218 star) (35.535 fork)batch import
help wantedopenssltest

Descrizione

  • Version: <= 10.13.0
  • Platform: Linux

when building with the --shared-openssl flag, it is highly probable that the openssl.cnf used by the shared library will be different than the one present in Node.js source code, resulting in several test failures. Typically, on debian, openssl is configured with stricter options regarding key length and TLS versions. It is very easy to avoid any test failure, though, by setting this environment variable when running tests: OPENSSL_CONF=./deps/openssl/openssl/apps/openssl.cnf

Guida contributor

Tech stack
nodejsjavascript
Dominio
testingbackend
Tipo issue
test
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Understanding of Node.js test suiteBasic knowledge of OpenSSL configuration
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
80
Direzione di ricerca
The issue suggests setting the OPENSSL CONF environment variable to the embedded openssl.cnf file when running tests with shared openssl. This can be implemented by modifying the test runner configuration, possibly in the Makefile or test scripts. Look at the test configuration files in the repository, such as 'Makefile' or 'test/common/' to add the environment variable.