nodejs/llnode

Apply env variables to test timeouts consistently

Aperta

#407 aperta il 20 ago 2022

 (0 commenti) (0 reazioni) (0 assegnatari)C++ (101 fork)github user discovery
good first issuehelp wanted

Metriche repository

Star
 (1167 stelle)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

The test suite currently defines a session timeout for tests based on process.env.TEST_TIMEOUT https://github.com/nodejs/llnode/blob/main/test/common.js#L173 This timeout has recently been incremented due to the restricted resources in GH Actions.

The timeout also isn't applied to all the tests and some have been overridden directly in the code base for longer tests. https://github.com/nodejs/llnode/blob/ff75da7eb151cf8d7481eba9a1c6406a53c85ce5/test/plugin/workqueue-test.js#L29

A suggested approach is to have process.env.TEST_TIMEOUT and a new process.env.TEST_TIMEOUT_LONG consistently applied across the project so that the GH Actions can be incremented without modifying code and local development can shorten a test run by decreasing the same environment variables on the local machine.

Guida contributor