ninja-build/ninja

Signal handling does not work as expected

Open

#1241 aperta il 16 feb 2017

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)C++ (1544 fork)batch import
help wanted

Metriche repository

Star
 (10.194 star)
Metriche merge PR
 (Merge medio 39g 3h) (10 PR mergiate in 30 g)

Descrizione

Ninja on POSIX systems currently puts children in their own process group. This policy causes a variety of problems, since ninja doesn't perfectly forward signals to children --- for example, C-z in the terminal sends a SIGTSTP (and then SIGSTOP) to ninja, but since ninja doesn't do anything special for SIGTSTP, the compilation jobs keep running. SIGINT frequently doesn't interrupt compilation jobs either.

In GNU Make, all of these interactions work as you'd expect.

Why do we need to put subprocesses in their own process group? This whole issue disappears if we don't put children in their own process groups, let them inherit the controlling terminal, and allow signal propagation to work normally.

Guida contributor