nextcloud/server

Enable usage of svg favicons and remove imagick from iconbuilder

Open

Aperta il 8 feb 2023

Vedi su GitHub
 (11 commenti) (4 reazioni) (0 assegnatari)PHP (34.953 star) (4865 fork)batch import
1. to developfeature: theminghelp wantedtechnical debt

Descrizione

This allows us to get rid of using imagick in iconbuilder of the theming app, which in return allows us to not enforce this requirement anymore since gd and imaginary can be used for all other tasks.

Julius found this: https://www.leereamsnyder.com/blog/favicons-in-2021#safari-does-not-fully-support-svg-icons

cc @juliushaertl

Guida contributor

Tech stack
php
Dominio
backend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
PHPNextcloud server architectureTheming app concepts
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
55
Direzione di ricerca
The issue involves enabling SVG favicons in the iconbuilder of the theming app and removing the imagick dependency. The code is likely in the 'theming' app directory. Review the linked blog post about Safari SVG favicon support. Check comments for any ongoing work or additional requirements. Ensure that the replacement using gd and imaginary handles all icon types. No linked PRs exist, so implement the changes from scratch, testing with various browsers.