nextcloud/android

Checking for latest version at every "All files" screen

Open

Aperta il 18 gen 2018

Vedi su GitHub
 (3 commenti) (1 reazione) (0 assegnatari)Java (3752 star) (1719 fork)batch import
bugdev versiongood first issuepapercut

Descrizione

Actual behavior

When I go to the root "all files" screen, the app checks if the last version is installed. I have a small lag (sometimes a fast blackscreen), and I have the message about version "No new version" or "New version available". If I use NC app and my smartphone became locked, I unlock and the screen of NC have the same behavior (lag + message at bottom)

Expected behaviour

No lag, why not just notification in the notification bar of android ? A check when I am in "expert mode" only ? A check when I am in settings only ? A check per day ?

Steps to reproduce

  1. Go to the "home" page "All files"

Environment data

Android version: 7.1.2

Device model: Nexus 4

Stock or customized system: Lineageos 14.1

Nextcloud app version: 20180118

Nextcloud server version: 12.0.4

Guida contributor

Tech stack
androidjava
Dominio
mobileperformance
Tipo issue
performance
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Android development environmentJava knowledge
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
65
Direzione di ricerca
Examine the 'All files' screen code to identify where the version update check is performed. Look for an update checker class or a network call in the activity lifecycle. Consider moving the check to a background task that runs at most once per day or moving it to the settings screen. The repository is Java based, so focus on Java source files in the app module.