ndelvalle/v-click-outside

The isActive config is ignored when updated dynamically

Open

Aperta il 8 nov 2019

Vedi su GitHub
 (2 commenti) (0 reazioni) (1 assegnatario)JavaScript (959 star) (90 fork)batch import
bughelp wanted

Descrizione

I'm trying to disable the behavior of the click outside dynamically by changing the isActive property of the config object but the behavior still the same.

I know I can use the middleware to handle this (check line 36) but I don't know if the config of click outside expects to be dynamically.

https://codesandbox.io/s/v-click-outside-e4vin

Guida contributor

Tech stack
javascriptvue
Dominio
frontend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Understanding of Vue reactivityFamiliarity with Vue directives
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
35
Direzione di ricerca
The issue is that the `isActive` property in the config object is not being observed when changed dynamically. The fix likely involves adding a watcher or recomputing the directive's behavior when `isActive` changes. Check the source file `src/directive.js` for how the config is bound and if there's a mechanism to react to changes. The CodeSandbox linked in the issue (https://codesandbox.io/s/v click outside e4vin) demonstrates the problem. The assignee might have insights; review any existing comments or PRs for potential solutions.