firefoxhelp wantedinframetricsquestion
Metriche repository
- Star
- (28 star)
- Metriche merge PR
- (Metriche PR in attesa)
Descrizione
Vet the Firefox-launch code in wptagent here; it might help us understand or at least unfurl our versioning issue over in https://github.com/mozilla/wpt-api/issues/125 and https://github.com/WPO-Foundation/wptagent/issues/216:
Just some things that stood out on a cursory look-through:
- hardcoded Marionette port (might be correct/OK, but maybe it could be dynamic (scanning for other open ports, or does marionette_client/driver do that already?)
- hardcoded sleep(s): https://github.com/WPO-Foundation/wptagent/blob/84018f548a2dea78dfca0ca64c19386adc6e2bca/internal/firefox.py#L131
- user-agent reading/overriding, etc.
- the "Wait for [Firefox] browser startup to finish" code: https://github.com/WPO-Foundation/wptagent/blob/84018f548a2dea78dfca0ca64c19386adc6e2bca/internal/firefox.py#L172-L173
- the exception handling/debug-info returning code here: https://github.com/WPO-Foundation/wptagent/blob/84018f548a2dea78dfca0ca64c19386adc6e2bca/internal/firefox.py#L174-L176
/cc @davehunt