mozilla/testpilot

Refine .eslintrc rules for node vs browser JS

Aperta

#3228 aperta il 10 gen 2018

 (6 commenti) (0 reazioni) (0 assegnatari)FreeMarker (108 fork)auto 404
dev papercutgood first issueskill:js

Metriche repository

Star
 (250 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

As @pdehaan mentions:

What about just specifying the ESLint environment in the gulpfile.babel.js and webpack.config.js, a la /* eslint-env node, browser, whatever */. Or if we want to set the node env for a directory, we could just use a nested .eslintrc file (for tests or gulp tasks or whatnot).

We've got a pretty broad set of globals and envs covering all of our JS for linting, right now. But, some JS is for the build chain in node and some are for running in the browser. Might be nice to use per-directory & file glob eslint overrides to further focus what's allowed for various source files.

Guida contributor