mozilla/mentat

Panic when leaving unused `:in` variable unbound

Open

#654 aperta il 23 apr 2018

Vedi su GitHub
 (5 commenti) (0 reazioni) (0 assegnatari)Rust (116 fork)github user discovery
A-querybuggood first bughelp wanted

Metriche repository

Star
 (1661 star)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

When leaving an :in variable unbound, like in:

[:find
 ?e
 :in
 ?f ?unused
 :where
 [(= e f)]
]

After binding only ?f, we panic at https://github.com/mozilla/mentat/blob/0c31fc7875294fdf80f4caf253590999a9214e0d/query-algebrizer/src/clauses/mod.rs#L147

That code is trying to be careful, but the issue is that the subtraction underflows in the above circumstance, since we're subtracting usize instances.

Guida contributor