monicahq/monica

Make SMS link clickable

Open

Aperta il 10 mag 2018

Vedi su GitHub
 (12 commenti) (0 reazioni) (0 assegnatari)PHP (24.641 star) (2464 fork)batch import
feature requestgood first issuehelp wanted

Descrizione

Right now SMS field is not clickable. It should be so it opens the default OS app that let you send messages.

https://developer.apple.com/library/content/featuredarticles/iPhoneURLScheme_Reference/SMSLinks/SMSLinks.html#//apple_ref/doc/uid/TP40007899-CH7-SW1

Guida contributor

Tech stack
phphtmlcssjavascript
Dominio
frontend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
basic HTML
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
80
Direzione di ricerca
The issue is to make the SMS field clickable so it opens the default messaging app. The body provides a reference to Apple's URL scheme for SMS links (sms: protocol). Look at the template or view file where the SMS field is rendered (likely in a contact detail page) and add an anchor tag with href="sms:{phone number}". Ensure the link works on both iOS and Android by using the tel: protocol as a fallback? Also check if there is a similar implementation for phone calls. The issue has 12 comments but no PRs, so review the discussion for any additional requirements.