monicahq/monica

Create a command to execute all commands that we need to run before pushing final commit to a PR

Open

Aperta il 12 apr 2018

Vedi su GitHub
 (1 commento) (0 reazioni) (1 assegnatario)PHP (24.641 star) (2464 fork)batch import
feature requesthelp wantedproductivity tools

Descrizione

Each time we need to push our final commit to a PR, we need to

  • php artisan lang:generate
  • npm run prod

And sometimes other stuff too.

Perhaps we could create a command php artisan finalize:pr or something that would do that for us.

Guida contributor

Tech stack
phpjavascript
Dominio
clideveloper experience
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
blocked
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Basic Laravel structureFamiliarity with Artisan commands
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
The issue requests a new Artisan command that runs `php artisan lang:generate` and `npm run prod`. To implement, look at existing commands in the `app/Console/Commands` directory to understand the pattern. For executing other Artisan commands, use the `Artisan::call()` facade. The command should be registered in `app/Console/Kernel.php`. Also, note that the command could accept additional arguments to run other steps. The assignee is currently assigned, so coordinate with them before starting.