Fix up minification · moment/luxon

(3 commenti) (0 reazioni) (0 assegnatari)JavaScript (759 fork)batch import

help wantedissue: infrastructure

Metriche repository

Right now, we use a slightly brokeass minification system. Here's what happened:

Originally, we had minification built into our Rollup pipeline. This is the best way to do the minification because it gets the map files right and because it can (at least in theory) be a bit smarter about the minification.
But it broke and caused all sorts of horribleness, as you can see in #357. I don't know what happened, but probably some part of the toolchain got upgraded and doesn't fit together right anymore
I switched the build to just run uglify on the output of the relevant transpile steps
You can switch between the old, better, broken method and the new, hacky, broken method by switching the TRUST_MINIFY const in build.js
Presumably the fix is either finding the right version of the toolchain deps or fiddling with some config.

Direzione di ricerca: Analizza la pipeline di build in tasks/build.js, in particolare la costante TRUST MINIFY. Confronta la vecchia minificazione basata su Rollup con l'attuale approccio basato su uglify. Identifica quale aggiornamento delle dipendenze ha causato il problema controllando le modifiche di versione in package.json. Prova a ripristinare la minificazione Rollup aggiornando i plugin Rollup o modificando la configurazione.
Tech stack: javascript
Dominio: build systemtooling
Tipo issue: Bug
Difficoltà: 3
Tempo stimato: Mezza giornata
Stato attività: Attiva
Chiarezza: Abbastanza chiara
Prerequisiti: JavaScriptNode.js
Adatta ai principianti: 45