mittwald/api-client-js

withAccessToken: allow dynamic tokens

Aperta

#46 aperta il 20 mar 2024

 (0 commenti) (0 reazioni) (0 assegnatari)TypeScript (0 fork)auto 404
enhancementgood first issue

Metriche repository

Star
 (2 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

https://github.com/mittwald/api-client-js/pull/45 introduced the common interceptor withAccessToken.

If changing the access-token at runtime should be supported (what I suppose is a real-world-use-case), the withAccessToken interceptor is not the right solution, because it would require to create a new client and replace all usages.

Maybe the token parameter could be a function (executed in the interceptor) or a variable bag { token: string } what can be mutated during runtime – but this is a not so common and reasonable approach.

Guida contributor