mirumee/ariadne

Make it possible to exempt some resolvers from tracing

Aperta

#859 aperta il 3 mag 2022

 (5 commenti) (1 reazione) (0 assegnatari)Python (194 fork)batch import
enhancementhelp wantedto do

Metriche repository

Star
 (2342 stelle)
Metriche merge PR
 (Merge medio 12g) (3 PR mergiate in 30 g)

Descrizione

The default behavior of only tracing custom resolvers is great 95% of the time, however there is a case for not to trace certain custom resolvers as well.

We have a few simple custom resolvers that can be called up to a couple thousand times per request where the tracing overhead becomes significant. Also, in our case they don't do meaningful work that would warrant tracing them.

Right now I see two ways to implement a workaround in our code-base without touching ariadne itself:

  1. Monkey-patch ariadne.contrib.tracing.should_trace function
  2. Add _ariadne_alias_resolver attribute to our own resolvers, disguising them as alias resolvers which are already exempt fro tracing.
  3. Extend the tracing extensions in our code to do the filtering.

The first two approaches are brittle and can break upon any update to ariadne. We can go forward using the third approach but we think it'd make sense to add this functionality in ariadne itself.

I'd like to contribute support for this functionality in ariadne if you accept my reasoning for the need of it. My plan is to add a filter callable to the tracing extensions that can look-up the field in a block-list or perform any other custom logic. An even less intrusive change could also be just adding a should_trace method in the tracing extensions that can be overridden in a subclass, instead of using a non-member function.

Guida contributor