Miss check for the return value of CXPLAT_ALLOC_NONPAGED and CxPlatPoolAlloc · microsoft/msquic#5233

(0 commenti) (1 reazione) (2 assegnatari)C (671 fork)github user discovery

Area: TestingHowFound: MSRTriagedgood first issuehelp wanted

Metriche repository

Star: (4712 star)
Metriche merge PR: (Metriche PR in attesa)

Descrizione

Description There are several instances in the codebase where the return value of CXPLAT_ALLOC_NONPAGED and CxPlatPoolAlloc is not checked before being used.

https://github.com/microsoft/msquic/blob/a6fe43d7928dc550b2f24599a2769df0358f963d/src/perf/lib/Tcp.cpp#L706-L707

https://github.com/microsoft/msquic/blob/a6fe43d7928dc550b2f24599a2769df0358f963d/src/core/unittest/RecvBufferTest.cpp#L55-L58

https://github.com/microsoft/msquic/blob/a6fe43d7928dc550b2f24599a2769df0358f963d/src/core/unittest/RecvBufferTest.cpp#L77-L79

https://github.com/microsoft/msquic/blob/a6fe43d7928dc550b2f24599a2769df0358f963d/src/core/unittest/RecvBufferTest.cpp#L78-L79

https://github.com/microsoft/msquic/blob/a6fe43d7928dc550b2f24599a2769df0358f963d/src/core/unittest/RecvBufferTest.cpp#L82-L84

https://github.com/microsoft/msquic/blob/a6fe43d7928dc550b2f24599a2769df0358f963d/src/platform/unittest/TlsTest.cpp#L588-L596

Suggested Fix Add a null check immediately after each CXPLAT_ALLOC_NONPAGED and CxPlatPoolAlloc call, and handle the failure case appropriately

Guida contributor

Direzione di ricerca: Aggiungi controlli null dopo ogni chiamata a CXPLAT ALLOC NONPAGED e CxPlatPoolAlloc nei file specificati per gestire i fallimenti di allocazione.
Tech stack: c
Dominio: networkingbackend
Tipo issue: Bug
Difficoltà: 2
Tempo stimato: 1-3 ore
Stato attività: Attiva
Chiarezza: Abbastanza chiara
Prerequisiti: C
Adatta ai principianti: 75

Metriche repository

Descrizione

Guida contributor

Ricevi issue Easy fresche nella tua inbox.