microsoft/Terminal
Missing operator delete/delete[] for some allocated objects
Aperta
#875 aperta il 17 mag 2019
Area-CodeHealthHelp WantedIssue-BugProduct-Conhost
Metriche repository
- Star
- (103.173 stelle)
- Metriche merge PR
- (Merge medio 27g 19h) (24 PR mergiate in 30 g)
Descrizione
Hi.
Looks like there are few places in the Terminal code where I can suspect a memory leaks due to missing operator delete or operator delete[].
These allocation sites can be grouped into following:
- raw
operator newwithoutoperator deletelike this https://github.com/Microsoft/Terminal/blob/master/src/cascadia/TerminalConnection/ConptyConnection.cpp#L191 - allocation by
operator newsome global object or class member (https://github.com/Microsoft/Terminal/blob/master/src/cascadia/TerminalControl/TermControl.cpp#L281) - allocation by
operator newsome memory in a function and return it by raw pointer, which can leak then.
Here is my gist with quite a simple grep foroperator new calls - https://gist.github.com/dreamer-dead/c43248466fc4d445378b4dfba80d8d25
Is this an intentional behaviour or a bug that should be fixed?