microsoft/Terminal
Vedi su GitHubDefer initial terminal sizing until terminal initialization
Open
#3182 aperta il 13 ott 2019
Area-RenderingArea-UserInterfaceHelp WantedIssue-TaskProduct-Terminal
Metriche repository
- Star
- (35.764 star)
- Metriche merge PR
- (Merge medio 27g 19h) (24 PR mergiate in 30 g)
Descrizione
Right now the initial window size is calculated just as the window is created but before the terminal is. This has two disadvantages:
- It doesn't have all the size information. Right now its only the width of a scrollbar that it has to guess but there could be more (potentially variable size) elements in the future. There might also be some additional spacing in layers above, like pane or terminal page.
- It creates temporary
DxRendererjust to locate required fond and calculate its size and then discards it.
If we instead calculated the initial size when terminal initializes this problems would be gone (it would be able to query sizes of the controls and use the real renderer of a terminal). We might potentially resolve them otherwise but this seems to be the simplest and most robust approach.
The problem is that it could result in two sizing operations (one when window opens and another one when the size is calculated) which could be noticeable to user or CPU, unless this can be somehow avoided. Thus I'm here to ask what do you think about this approach.