micrometer-metrics/micrometer

DNS, SSL, and TCP metrics for Apache HttpClient

Chiusa

#1617 aperta il 1 ott 2019

Vedi su GitHubGuida contributor
 (5 commenti) (0 reazioni) (1 assegnatario)Java (1131 fork)batch import
enhancementhelp wantedinstrumentationmodule: micrometer-core

Metriche repository

Star
 (4882 stelle)
Metriche merge PR
 (Merge medio 1g 21h) (100 PR mergiate in 30 g)

Descrizione

Add metrics for:

  1. DNS resolution time (inject custom DnsResolver, delegating to the user-provided resolver, and timing).
  2. SSL handshake time (inject SSLConnectionSocketFactory, delegating).
  3. TCP connect time (also in custom SSLConnectionSocketFactory).

Apply these on custom PoolingHttpClientConnectionManager.

Feedback suggests that DNS resolution/SSL handshake can go up dramatically in noisy neighbor situations.

Originally posted by @jkschneider in https://github.com/micrometer-metrics/micrometer/issues/533#issuecomment-446713248

Guida contributor

Direzione di ricerca
Investigate injecting custom DnsResolver and SSLConnectionSocketFactory into PoolingHttpClientConnectionManager. Review Apache HttpClient documentation for hooks. Examine existing Micrometer instrumentation patterns for timing using Timer. Consider the noisy neighbor scenario mentioned in the issue. Look at the original comment by jkschneider for context.
Tech stack
java
Dominio
observability
Tipo issue
Funzionalità
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
4
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
3-5 giorni
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Datata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
JavaApache HttpClientMicrometerSSL/TLS basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
35