[UI] ConfirmationModal.tsx disables all TypeScript checks via @ts-nocheck
#18.405 aperta il 2 apr 2026
Metriche repository
- Star
- (10.013 star)
- Metriche merge PR
- (Merge medio 22g 16h) (332 PR mergiate in 30 g)
Descrizione
Description
ui/components/ConfirmationModal.tsx has // @ts-nocheck at the top of the file, which disables all TypeScript type checking for the entire component.
File: ui/components/ConfirmationModal.tsx:1
// @ts-nocheck
Why This Is a Problem
@ts-nocheck suppresses all TypeScript errors in the file, defeating the purpose of using TypeScript. This means:
- Type errors in this component pass silently and are only discovered at runtime
- Incorrect prop types won't be caught during development
- Refactors that change interfaces won't produce errors in this file
- Code review cannot rely on TypeScript to catch regressions here
ConfirmationModal is used throughout the application as a shared component, making silent type errors here high-impact.
Expected Behavior
The @ts-nocheck directive should be removed and any underlying type errors should be properly resolved with correct TypeScript types.
Steps to Reproduce
- Open
ui/components/ConfirmationModal.tsx - Observe line 1:
// @ts-nocheck
Suggested Fix
Remove // @ts-nocheck, address any TypeScript errors that surface, and add proper type annotations for props and state.