meshery/meshery

[UI] ConfirmationModal.tsx disables all TypeScript checks via @ts-nocheck

Open

Aperta il 2 apr 2026

Vedi su GitHub
 (8 commenti) (0 reazioni) (1 assegnatario)HTML (10.013 star) (3101 fork)batch import
component/uiframework/reactgood first issueissue/validkind/buglanguage/javascript

Descrizione

Description

ui/components/ConfirmationModal.tsx has // @ts-nocheck at the top of the file, which disables all TypeScript type checking for the entire component.

File: ui/components/ConfirmationModal.tsx:1

// @ts-nocheck

Why This Is a Problem

@ts-nocheck suppresses all TypeScript errors in the file, defeating the purpose of using TypeScript. This means:

  1. Type errors in this component pass silently and are only discovered at runtime
  2. Incorrect prop types won't be caught during development
  3. Refactors that change interfaces won't produce errors in this file
  4. Code review cannot rely on TypeScript to catch regressions here

ConfirmationModal is used throughout the application as a shared component, making silent type errors here high-impact.

Expected Behavior

The @ts-nocheck directive should be removed and any underlying type errors should be properly resolved with correct TypeScript types.

Steps to Reproduce

  1. Open ui/components/ConfirmationModal.tsx
  2. Observe line 1: // @ts-nocheck

Suggested Fix

Remove // @ts-nocheck, address any TypeScript errors that surface, and add proper type annotations for props and state.

Guida contributor

Tech stack
typescriptreact
Dominio
frontend
Tipo issue
refactor
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
active
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
TypeScript
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
75
Direzione di ricerca
Rimuovi il commento @ts nocheck e risolvi gli errori TypeScript in ConfirmationModal.tsx aggiungendo annotazioni di tipo corrette per props e state. Inizia aprendo il file ed eseguendo `npx tsc noEmit` per vedere gli errori, poi correggili uno per uno.