meilisearch/MeiliSearch
Improve GitHub CI manifest: remove useless `matrix`?
Aperta
#2891 aperta il 11 ott 2022
contribution acceptedgithub actionshelp wantedmaintenanceOLD
Metriche repository
- Star
- (57.572 stelle)
- Metriche merge PR
- (Merge medio 11g 20h) (41 PR mergiate in 30 g)
Descrizione
In this manifest file, we have two jobs we could maybe refactor
publish-aarch64-> https://github.com/meilisearch/meilisearch/blob/0f024e7d97568d3763c2817cbea67008e90dfa2d/.github/workflows/publish-binaries.yml#L108-L176publish-macos-apple-silicon-> https://github.com/meilisearch/meilisearch/blob/0f024e7d97568d3763c2817cbea67008e90dfa2d/.github/workflows/publish-binaries.yml#L70-L106
The issue with both of these jobs is they ar using matrix without using the real purpose of matrix, I mean, running multiple times the same job with different contexts described in the matrix. Here the matrix are arrays of 1 single element.
I wanted to know if it would be possible to have the same job working without matrix BUT ⚠️ ⚠️
- I don't want the information to be hard written in the job: I like the face we have all the information at top of the job
- It means I want an alternative only if it exits a GitHub action way to declare kind of variables available for the job, at the top of the job
Maybe matrix is the best solution, in this case, I cannot ensure we will merge your PR if you suggest something.
Thanks in advance for your help ❤️