matthewmueller/x-ray

Better Stream Support

Open

#160 aperta il 26 mar 2016

Vedi su GitHub
 (0 commenti) (2 reazioni) (0 assegnatari)JavaScript (415 fork)batch import
enhancementepichelp wanted

Metriche repository

Star
 (5804 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

Currently stream support is poor.

I'm doing experiments on my computer and under stream error nothing happens and this is totally dangerous.

Also I've noticed that code is dirty because first, need to handle callback of the requests, and later, handle the stream interaction (that could be a noop method, lol)

It could be more simple just handling the data as stream (Before my experienced creating fetch-timeline, I think that from2 is the right way, maybe JSONStream too) and, if a callback is provided, convert the stream into a callback interaction (for example, using read-all-stream).

This feature/refactor is very important to support filter/transform data with perfomance.

Guida contributor