Bulk Importer: Do not stop on first error when validating an import file
#16.305 aperta il 18 nov 2020
Metriche repository
- Star
- (32.880 stelle)
- Metriche merge PR
- (Merge medio 6g 5h) (318 PR mergiate in 30 g)
Descrizione
The bulk importer currently immediately exits when it is validating an import file and the first error is found.
While this is helpful during actual application of the file it is definitely not helpful when running the validation. As part of this ticket, when the import process gets an error, we should check if it's being run with the dryRun flag enabled, and if so, the process should only print the error and keep going, so all the errors get printed before the validation ends.
The bulk import is called as part of the cmd/mattermost/commands/import.go file, in the bulkImportCmdF function, and its entrypoint in the application layer is the BulkImport function in the app/import.go file.
If you have questions about the ticket or you need any help, please contact miguel.delacruz in https://community.mattermost.com/ or post your question in the Community Developers channel.
If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
New contributors please see our Developer's Guide.