mapbox/mapbox-gl-js

Expose a "statechange" event on GeolocateControl

Open

#5136 aperta il 11 ago 2017

Vedi su GitHub
 (0 commenti) (2 reazioni) (0 assegnatari)JavaScript (2203 fork)batch import
feature :green_apple:good first issue

Metriche repository

Star
 (10.532 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

Motivation

Discussion started here: https://github.com/mapbox/mapbox-gl-js/pull/4479#issuecomment-321203924

The GeolocateControl doesn't expose events necessary to act on all of its states. trackuserlocationstart and trackuserlocationend aren't enough to detect some user actions. For instance, it's impossible to know if the user toggled off tracking.

To achieve this I currently have to use a MutationObserver on the .mapboxgl-ctrl-geolocate watching for classList changes.

Design

Fire a new statechange event on every _watchState change and pass along its value.

Implementation

Replace all this._watchState = ... with:

_setState(state) => {
  if (this._watchState !== state) {
    this._watchState = state
    this.fire('statechange', state)

    // ... conditions logic to fire trackuserlocationstart and trackuserlocationend
  
    // bonus?
    this._updateUI(state) // centralize the different classList updates spread in _onSucces, _onError, _onClick...
  }
}

Guida contributor