[-Wunsafe-buffer-usage] Warn about two-arg string view constructors
#166.644 aperta il 5 nov 2025
Metriche repository
- Star
- (26.378 star)
- Metriche merge PR
- (Merge medio 1g 2h) (1000 PR mergiate in 30 g)
Descrizione
The two-arg form of std::span<> will currently produce a warning when used along with the -Wunsafe-buffer-usage-in-container option, subject to heuristics that try to determine suspicious arguments.
The string view types, (actually std::basic_string_view<>) have the same issues as does std::span<> when used with a two-argument constructor.
Since the name of the -W flag says "container", I humbly propose covering this case under the same warning, and produce the same waring when encountered.
A small task is removing the specific mention of std::span<> from the diagnostic, expanding it to imply other containers.