linebender/druid

Sameness for fresh clones

Open

#944 aperta il 15 mag 2020

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)Rust (567 fork)batch import
D-Easydocshelp wanted

Metriche repository

Star
 (9091 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

Would it make sense to add to the doc of Data::same that the following property is recommended (or even required)?

assert!(x.same(&x.clone()))

I'm asking because there were some confusion about how to implement Data::same for im::Vector in https://github.com/bodil/im-rs/issues/117 and https://github.com/bodil/im-rs/issues/129. The current doc of Data::same would even allow the following implementation.

impl Data for Foo {
    fn same(&self, _other: &Self) -> bool {
        false
    }
}

Guida contributor