leostera/minttea

Implement Margin and fix Padding on Spices

Open

#4 aperta il 14 dic 2023

Vedi su GitHub
 (0 commenti) (1 reazione) (0 assegnatari)OCaml (32 fork)github user discovery
enhancementgood first issuehelp wanted

Metriche repository

Star
 (462 star)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

At the moment the padding_* properties are happening after the styles are applied to the text, which means padding doesn't behave like you'd expect it to. If you add padding to something with background, the padded space doesn't have the background.

In the Spices.do_render private function there's a section where we're handling the padding, that would become about margin_* instead:

https://github.com/leostera/minttea/blob/main/spices/spices.ml#L120-L124

And then similar code for padding would be added earlier on that function, where we do the core rendering of the string.

Guida contributor