kubernetes/minikube

Changing a Service from type: LoadBalancer to type: ClusterIP doesn't remove status.loadBalancer.ingress[]

Open

#9972 aperta il 15 dic 2020

Vedi su GitHub
 (7 commenti) (0 reazioni) (1 assegnatario)Go (5222 fork)batch import
help wantedkind/buglifecycle/frozenlong-term-supportpriority/backlog

Metriche repository

Star
 (31.799 star)
Metriche merge PR
 (Merge medio 12g 19h) (43 PR mergiate in 30 g)

Descrizione

Steps to reproduce the issue:

  1. minikube start --memory 8192 --cpus 8 --disk-size 80g
  2. minikube tunnel
  3. Create a Service my-svc with type: LoadBalancer
  4. Observe kubectl get service my-svc -o yaml shows status.loadBalancer.ingress[0].ip with the service's clusterIP
  5. kubectl patch service my-svc --type=merge -p "spec: {type: ClusterIP}"

Actual:

status.loadBalancer.ingress[0].ip remains.

Expected:

status.loadBalancer.ingress should be removed.

This would help automated tests that need to work with both minikube and cloud k8s clusters like GKE, that test adding and removing external access on Service.

We took a look at LoadBalancerEmulator, and saw that it has a method cleanupService(). However, it is only called on Services with type: LoadBalancer, and the cleanup methods are only called during shutdown.

Ideally, it seems like PatchServices should reconcile all Services to add or remove status.loadBalancer.ingress as appropriate.

Guida contributor