kubernetes/ingress-nginx

Support standard Forwarded header

Open

Aperta il 1 ago 2023

Vedi su GitHub
 (15 commenti) (9 reazioni) (2 assegnatari)Go (15.199 star) (7888 fork)batch import
good first issuehelp wantedkind/featurepriority/backlogtriage/accepted

Descrizione

As far as I can see the ingess controller currently just supports the "non-standard" X-Forwarded-* headers. It would be nice to support also the standard Forwarded header.

Use case

Keycloak has added support for the Forwarded header with version 21.0.0 and advices reverse-proxies to override this header.

Guida contributor

Tech stack
go
Dominio
backendapi
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
blocked
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Go programmingHTTP header knowledgeKubernetes ingress basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
The issue requests adding support for the standard Forwarded HTTP header alongside the existing X Forwarded * headers. Key files to investigate are likely in the internal/ingress/controller or pkg/ingress directories, where header handling is implemented. Review the current X Forwarded * logic and adapt it to handle the Forwarded header per RFC 7239. The Keycloak release notes provide context on why this is needed. Check if there are any linked PRs or comments about implementation approach.