kubernetes-sigs/kubectl-validate

GitHub downloader subject to rate limits

Open

#17 aperta il 4 mag 2023

Vedi su GitHub
 (2 commenti) (0 reazioni) (1 assegnatario)Go (56 fork)auto 404
good first issue

Metriche repository

Star
 (268 star)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

For unsupported schemas we have the option of downloading them from GitHub. This requires 1 or 2 api calls to list Kubernetes source directories. GitHub responses support E-Tags in their responses so can be cached without affecting the rate limit. We should add an on-disk cache similar to kubectl that stores the etags.

Another improvement would be to use the GitHub api key if supplied in envar or argument. That way the test suite would not ever be subject to rate limiting.

Guida contributor