How to surfacing runtime hook blocking cluster deletion in condition
#6807 aperta il 2 lug 2022
Metriche repository
- Star
- (4267 stelle)
- Metriche merge PR
- (Metriche PR in attesa)
Descrizione
Details:
This issue is to discuss how to surface that a cluster deletion is blocked when the BeforeClusterDelete hook blocks the deletion of a process with a blocking response.
We have 2 options:
-
Use
TopologyReconciledcondition - Since only managed clusters are affected byBeforeClusterDeletehook we can use theTopologyReconciledcondition to surface if a cluster deletion is blocked. Reason will beLifecycleHookBlocking. This will be consistent with how the other lifecycle hook blocking cases are surfaced. -
Use a separate condition - Since
TopologyReconciledcondition reflects if the underlying objects reflect the topology spec of the cluster using it for delete might be deviating from it purpose.
Some additional concerns:
- How should the condition be updated after deletion is unblocked and the cluster is in the process of deleting the objects?
- Which controller owns this condition?
/area runtime-sdk