kubernetes-sigs/cluster-api

Improve UX of MachineHealthCheckStatus fields

Aperta

#5291 aperta il 22 set 2021

 (15 commenti) (0 reazioni) (0 assegnatari)Go (1532 fork)auto 404
help wantedkind/api-changekind/featurepriority/important-longtermtriage/accepted

Metriche repository

Star
 (4267 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Description

MHC currently has the following columns: MaxUnhealthy, ExpectedMachines, CurrentHealthy. Based on this columns it's a bit hard to grasp what's going on.

The fields have the following semantic (or at least godoc):

  • .spec.maxUnhealthy: Any further remediation is only allowed if at most "MaxUnhealthy" machines selected by "selector" are not healthy.
  • .status.expectedMachines: total number of machines counted by this machine health check
  • .status.currentHealthy: total number of healthy machines counted by this machine health check

A few examples:

  • field name: unhealthy vs healthy (would be easier to have either healthy or unhealthy twice, if possible)
  • expectedMachines: what does expected mean? according to the godoc it's (probably) the number of machines which match the selector
  • currentHealthy: not sure if we need current if it's part of the status (as far as I can see in our other types we're not using the current prefix)

/kind feature

Guida contributor