KCP: Consider reconciling on Pod events · kubernetes-sigs/cluster-api

(10 commenti) (0 reazioni) (1 assegnatario)Go (1532 fork)auto 404

help wantedkind/featurepriority/important-longtermtriage/accepted

Metriche repository

Star: (4267 stelle)
Metriche merge PR: (Metriche PR in attesa)

Descrizione

We recently changed KCP to use a cached client to retrieve the Pods we care about.

This means we already have informers for Pods of workload clusters.

I'm wondering if we should also trigger reconciles if these Pods change (similar to how we watch on Node events in the Machine controller).

Pro

we can instantly react to Pod changes instead of using requeue after

Con

we get probably more reconciles
- This can be mitigated by only letting the update events through that we care about or by rate-limiting. This might even lead to less reconciles when we get rid of the requeues we have because we don't watch on Pod events (https://github.com/kubernetes-sigs/cluster-api/blob/d9341254c25ca578f9c82d5cf69f58c1ffc59a9b/controlplane/kubeadm/internal/controllers/controller.go#L253)

Guida contributor

Direzione di ricerca: Indaga come aggiungere la riconciliazione degli eventi Pod al controller KCP, considerando gli informer e le strategie di limitazione della velocità.
Tech stack: go
Dominio: backendapi
Tipo issue: Funzionalità
Difficoltà: 3
Tempo stimato: Mezza giornata
Stato attività: Attiva
Chiarezza: Chiara
Prerequisiti: GoKubernetesKCP
Adatta ai principianti: 40