[Feature]: PodSet Container to support Image and Command

(12 commenti) (0 reazioni) (0 assegnatari)Go (964 fork)github user discovery

good first issuehelp wantedkind/cleanupkind/feature

Metriche repository

Star: (2112 stelle)
Metriche merge PR: (Metriche PR in attesa)

Descrizione

What you would like to be added?

Problem: If we want to manipulate a Container or InitContainer on the JobSet, e.g., here we need to expose the Image and Command for the InitContainer, which are generally needed. We cannot use PodSet for InitContainer without this exposure. The ultimate goal is to have the PodSet interface map onto the actual Jobset (e.g., PodSet -> runtime.Container -> JobSet) with changed Image and Command. Note that tests can then be refactored too (reference)

Why is this needed?

Customization of Image/Command for InitContainers is generally desired. For the Flux Policy PR/integration we are not able to use PodSet without it: https://github.com/kubeflow/trainer/pull/3064#issuecomment-3815049315

Love this feature?

Give it a 👍 We prioritize the features with most 👍

Guida contributor

Direzione di ricerca: Esamina l'interfaccia PodSet nel pacchetto runtime, traccia come vengono attualmente gestiti i container (es. in runtime.go) ed estendi l'interfaccia per esporre Image e Command. Fai riferimento alla PR collegata (#3064) per il contesto dell'integrazione Flux Policy.
Tech stack: go
Dominio: backend
Tipo issue: Funzionalità
Difficoltà: 3
Tempo stimato: 1-2 giorni
Stato attività: Attiva
Chiarezza: Chiara
Prerequisiti: GoKubernetes
Adatta ai principianti: 40