keystonejs/keystone-classic

Code format lost if using dependsOn

Open

Aperta il 4 apr 2018

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)JavaScript (14.656 star) (2288 fork)batch import
bughelp wanted

Descrizione

Expected behavior

When using dependsOn in a Type.Code field, it should keep its code formating.

Actual/Current behavior

When using dependOn in Type.Code field, the format defaults to a plain text field.

Steps to reproduce the actual/current behavior

code: {type: Types.Code, dependsOn: {type: "code"}"}

Environment

Software Version
Keystone 4.0.0-beta.5
Node v8.10.0

Guida contributor

Tech stack
javascriptnodejs
Dominio
backend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Basic understanding of Keystone field typesFamiliarity with dependsOn
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
35
Direzione di ricerca
Examine the Code field type implementation, likely in `fields/types/Code.js`. Investigate how `dependsOn` affects the field's rendering: the issue reports that the code format (editor) is lost and defaults to a plain text field when `dependsOn` is used. Look at the field definition and any conditional logic that might disable the code editor. Since no comments or PRs exist and the issue is from 2018, first verify if the bug persists in the current version of keystone classic. If reproducing, check the related field type registration and how `dependsOn` is processed during field initialization.