keystonejs/keystone-classic

Prompt to save changes to a post before navigating away

Open

Aperta il 1 nov 2017

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)JavaScript (14.656 star) (2288 fork)batch import
feature requesthelp wanted

Descrizione

Expected behavior

We should track when changes are made to the form since the last save, and if the user is navigating away from the edit page while there are unsaved changes, prompt them to save or to confirm their navigation action.

Actual/Current behavior

Current behavior is that there is no check for unsaved changes. If the user accidentally navigates away from the edit page, then these changes are lost.

Steps to reproduce the actual/current behavior

  1. Select a post from the admin page to edit
  2. On the edit screen, make some changes to the post
  3. Navigate away from the edit screen without clicking the save button

At this point, if you view the selected post, the unsaved changes will be lost.

Environment

Software Version
Keystone master branch of the repo (npm linked)
Node 6.11.2

Guida contributor

Tech stack
javascriptreactnodejs
Dominio
frontend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
ReactJavaScript event handling
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
Examine the admin UI code for editing posts, likely in a React component. Look for how navigation is handled (e.g., React Router) and implement a `beforeunload` event or a custom prompt. Check if there are existing hooks for form dirtiness (like `useState` with `isDirty`). Review similar features in the repo or linked resources. The maintainer has not provided additional guidance, so the contributor should start by reading the current form submission code path.