keystonejs/keystone-classic

babel settings in root directory are used for keystone module

Open

Aperta il 30 ott 2017

Vedi su GitHub
 (4 commenti) (1 reazione) (0 assegnatari)JavaScript (14.656 star) (2288 fork)batch import
bughelp wanted

Descrizione

Expected behavior

Admin.js should not fail with errors

Actual/Current behavior

When using the transform-runtime plugin for babel admin.js crashes with

TypeError: $export is not a function

as babel-polyfill is reading .babelrc or package.json.

Steps to reproduce the actual/current behavior

create a babelrc file with plugin: transform-runtime

Environment

Software Version
Keystone 4.0.0-beta.7
Node 6.10

Guida contributor

Tech stack
javascriptnodejs
Dominio
backend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Basic knowledge of Babel configurationFamiliarity with Node.js module resolutionUnderstanding of Keystone admin.js build processAbility to test changes locally
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
The issue occurs when a user's .babelrc file with transform runtime plugin conflicts with Keystone's admin.js build. Investigate how Keystone loads Babel configuration; likely the admin module inherits root .babelrc settings. Check the Keystone repository for its own Babel config (e.g., in `admin/` or `keystone/` packages). Consider isolating the admin module's Babel config using `env` or a custom `.babelrc` that overrides root settings. Reproduce the bug by creating a test project with transform runtime and running admin.js. Look at the keystone classic source code for babel configuration to identify the exact files involved.