[Bug] deserialize_keras_object raises AttributeError for invalid config types

(6 commenti) (0 reazioni) (1 assegnatario)Python (19.746 fork)batch import

Good first issuebackend:tensorflowstat:contributions welcometype:Bug

Metriche repository

Star: (64.232 stelle)
Metriche merge PR: (Merge medio 6g 23h) (75 PR mergiate in 30 g)

Descrizione

Description

deserialize_keras_object may raise AttributeError when provided with invalid config types (e.g., list or string), indicating that input validation occurs after internal method calls.

Reproduction Script

import os
os.environ["KERAS_BACKEND"] = "tensorflow"

from keras.saving import deserialize_keras_object

config = {
    "class_name": "Dense",
    "module": "keras.layers",
    "config": [1, 2, 3]   # invalid type
}

try:
    deserialize_keras_object(config)
except Exception as e:
    print("Exception type:", type(e).__name__)
    print("Message:", e)

Observed behavior

Raises AttributeError: 'list' object has no attribute 'get'

Expected behavior

Should raise a clear ValueError or TypeError for invalid input structure

Notes

This suggests input validation happens too late and exposes internal implementation details.

Guida contributor

Direzione di ricerca: The bug is in the `deserialize keras object` function, likely in `keras/saving/`. The fix involves adding input validation at the start to ensure `config` is a dict and raising a clear `ValueError` or `TypeError` instead of an `AttributeError`. Examine the existing comments in the issue for any suggested approaches or additional context. The change is localized and should include a simple type check before calling `.get()` on the config.
Tech stack: python
Dominio: backendmachine learning
Tipo issue: Bug
Difficoltà: 2
Tempo stimato: 1-3 ore
Stato attività: Bloccata
Chiarezza: Chiara
Prerequisiti: PythonError handling
Adatta ai principianti: 30