keithamus/jwerty

jwerty.is() not working in FF

Open

#38 aperta il 10 lug 2013

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)JavaScript (117 fork)batch import
help wanted

Metriche repository

Star
 (1214 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

// For each property in the jwertyCode object, compare to `event`
for (var p in jwertyCode[n]) {
    // ...except for jwertyCode.jwertyCombo...
    if (p !== 'jwertyCombo' && event[p] != jwertyCode[n][p]) returnValue = false;
}

I'm trying to check for key binding when clicking on an element but jwerty.is() does return false for 'shift', 'cmd' & 'alt'. After some minutes of debugging I've found the problem: You're getting the originalEvent which is in that case [object MouseEvent] and has no property keyCode for that reason. Therefore the result is always false. I'm not sure if there is a solution for this problem in FF, but it is working fine in Chrome. Thanks for this wonderful library!

Guida contributor