karma-runner/karma

script-launcher : bad script browser recognition

Open

#754 aperta il 23 set 2013

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)JavaScript (1703 fork)batch import
help wantedtype: backlogtype: feature

Metriche repository

Star
 (11.918 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

Hi all, just wanted to note that after updating to latest karma (0.10.2) , if someone's got problem with "script browsers" ( we use a .bat to run IE tester with specific IE versions) , it could be because of the "browser type recognition". It gets recognized as "script browser" only if it's path it's absolute

lib\launcher.js line 19

 // TODO(vojta): determine script from name
      if (name.indexOf('/') !== -1) {
        name = 'Script';
      }

we just put a temporary work-around like this

 // TODO(vojta): determine script from name
      if (name.indexOf('/') !== -1  || name.indexOf('.bat') !== -1) {
        name = 'Script';
      }

Guida contributor