Karma pseudo-reopens PhantomJS connection with asynchronous logging + captureConsole
#1908 aperta il 16 feb 2016
Metriche repository
- Star
- (11.918 stelle)
- Metriche merge PR
- (Metriche PR in attesa)
Descrizione
Our frontend code uses Bluebird, which asynchronously logs after tests are run to report unhandled rejections. Looking in Karma's karma.js, it seems these asynchronous logs are just piped down the WebSocket - even if the complete message has already been sent. Karma-side in browser.js, this info event restarts the disconnection timer, despite it having been closed down by the complete handler.
As such, Karma will hang after this happens, and after 10 seconds, a disconnection-due-to-timeout will fire, calling the Karma server's callback a second time (which, in our case, breaks Gulp).
Current workaround is to add captureConsole: false to the Karma client config, though we'd really like to see the logs as well when running via PhantomJS.