kantord/SeaGOAT

Support Mac OS. Help wanted 🙏🍎

Aperta

#178 aperta il 7 set 2023

 (9 commenti) (0 reazioni) (0 assegnatari)Python (91 fork)github user discovery
help wantedup for grabs

Metriche repository

Star
 (1302 stelle)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

At all steps, SeaGOAT is developed with guaranteeing Mac OS support. That being said, as I don't have a Mac OS device and I don't have expertise regarding Mac OS development workflows, I have not been able to verify that it works properly.

Help wanted!

Here is a rough checklist of the current status of Mac OS support:

  • Enable CI checks for Mac OS
  • Make sure that all CI tests pass for Mac
  • Manually test SeaGOAT on Mac
  • Document installation steps on Mac
  • Make sure that any required Mac-specific features are implemented
  • Make sure that it's easy to install on Mac using common tools (homebrew?)

Currently the main problem is that I have not been able to try and run SeaGOAT manually on OSX.

Also I have discovered that some of the tests are failing, so I created a CI file specifically for OSX that only checks some of the tests are are passing without issue:

https://github.com/kantord/SeaGOAT/blob/1edae8e4b9272906300046cf99bb5de8fd4256aa/.github/workflows/test-mac-os.yml#L56-L58

For comparison the Linux tests look like this:

https://github.com/kantord/SeaGOAT/blob/1edae8e4b9272906300046cf99bb5de8fd4256aa/.github/workflows/test.yml#L56-L58

Guida contributor