juspay/hyperswitch

[BUG]: Remove Basic keyword from shift4 API key

Open

#1438 aperta il 14 giu 2023

Vedi su GitHub
 (1 commento) (0 reazioni) (1 assegnatario)Rust (4676 fork)batch import
C-bugE-easyS-awaiting-triagegood first issue

Metriche repository

Star
 (42.690 star)
Metriche merge PR
 (Merge medio 6g 22h) (213 PR mergiate in 30 g)

Descrizione

Bug Description

While accepting api_key from user in shift4 currently we accept something like Basic c2tfdGVzdF93cjhMYjdqd1FvbwajkhfbQ6.

This Basic Keyword should not be there as if we only want to access the value of the key at some other authorization it would be difficult to extract.

Expected Behavior

The Basic key should be appended in the code like it is done for Bluesnap in bluesnap.rs .

Since we add Basic at code level we can only expect the actual key in the input from the user, rather than expecting the Basic key along with it.

Actual Behavior

Basic as keyword needs to be added in the api_key field under connector_account_details in create connector account api

Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

No, but I'm happy to collaborate on a PR with someone else

Guida contributor