jsx-eslint/eslint-plugin-react
Rule Proposal: Check for global references inside `render`
Aperta
#246 aperta il 13 ott 2015
acceptedhelp wantednew rule
Metriche repository
- Star
- (9293 stelle)
- Metriche merge PR
- (Metriche PR in attesa)
Descrizione
When using React for server rendering, it can be problematic when a component relies on window or document or other globals inside of render. It will cause checksum issues when you get to the client. Instead of checking whether you are on the client within render, it's better to use the componentDidMount lifecycle event to set a state which is used in render instead.
Problematic:
class Foo extends React.Component {
render() {
if (typeof window === 'undefined') {
return null;
}
return <Bar />;
}
}
Better:
class Foo extends React.Component {
constructor() {
this.state = {showBar: false};
}
componentDidMount() {
this.setState({showBar: true});
}
render() {
if (!this.state.showBar) {
return null;
}
return <Bar />;
}
}