jazzband/django-taggit

Enhacement: Add remove_by_slug() method to TaggableManager

Open

Aperta il 23 ago 2013

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)Python (3433 star) (624 fork)user submission
enhancementgood first issue

Descrizione

That way it would also be possible to remove tags by providing their unique slugs. Have in mind that people might want to use URLs like .../some-object/tags/my-precious-tag/remove/ to remove a tag.

Adding this method seems easy, but I am reluctant to contribute a PR because I am not sure if I can write correct tests for this code addition. If some guidance and supervision is provided I am willing to try.

Guida contributor

Tech stack
pythondjango
Dominio
backend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
PythonDjangodjango taggitDjango testing
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
65
Direzione di ricerca
The proposed method `remove by slug()` should be added to `TaggableManager` in `taggit/managers.py`. The existing `remove()` method can serve as a reference. Tests should be added in `taggit/tests.py` following patterns of existing test methods. The author expressed uncertainty about tests, so reviewing test structure and asking for maintainer clarification on expected behavior might be necessary.