jazzband/django-silk

Detect manual sql queries

Open

Aperta il 8 ott 2015

Vedi su GitHub
 (8 commenti) (14 reazioni) (0 assegnatari)Python (3958 star) (319 fork)batch import
enhancementhelp wanted

Descrizione

At the moment silk does its magic by hijacking execute_sql, but this doesn't catch RawQuerySet queries and certainly doesn't catch queries that use the bare cursor.execute, so these appear as time spent in python and the final sql doesn't get logged for nice introspection.

It may be tricky, but it would be nice if silk were able to catch these queries too, possibly by doing the hijacking at a lower level.

Guida contributor

Tech stack
pythonsql
Dominio
backenddatabaseperformance
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Understanding of Django's SQL execution internalsFamiliarity with monkey patching
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
The issue proposes detecting manual SQL queries (RawQuerySet, cursor.execute) that bypass the existing execute sql hook. Research Django's database backend implementation, focusing on the CursorWrapper class and how connections execute SQL. Consider intercepting at the cursor level or the database driver adapter level. Review any linked PRs or comments for prior attempts. Ensure the solution captures all SQL while maintaining compatibility with existing profiling.