jazzband/django-silk

Profiles don't seem to be created

Open

Aperta il 4 ott 2017

Vedi su GitHub
 (5 commenti) (0 reazioni) (0 assegnatari)Python (3958 star) (319 fork)batch import
help wanted

Descrizione

Using the latest master version, there seems to me that the only way to get profiling is to decorate a method/function with the silk_profile decorator.

The only place where Profile objects are created is here, and it happens for every profile object given by the DataCollector.profiles method. Now those profile objects are only registered using the register_profile in the _finalise_queries method which is part of the silk_profile decorator. From what I found, the decorator is only used for dynamic profiling throughout the project.

Note that the .prof files are being generated correctly.

Am I doing something wrong here?

Guida contributor

Tech stack
python
Dominio
backendperformance
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Django request lifecyclePython decoratorsSilk's profiling pipeline
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
Investigate the middleware's profiling logic in silk/middleware.py to understand how requests are automatically profiled. Compare with the manual decorator path in silk/profiling/profiler.py. Determine why Profile objects are only created during the decorator's finalise queries method and not during normal request processing. Check if the DataCollector.profiles method is being called in the automatic path and if so, why Profiler objects are not registered.