jantimon/favicons-webpack-plugin

Make sure examples work

Aperta

#295 aperta il 9 gen 2022

 (1 commento) (0 reazioni) (0 assegnatari)JavaScript (205 fork)batch import
help wantedwontfix

Metriche repository

Star
 (1200 stelle)
Metriche merge PR
 (Merge medio 4m) (1 PR mergiata in 30 g)

Descrizione

Is your feature request related to a problem? Please describe. I downloaded the repo, installed Node.js v10.20.0, and installed dependencies. Then I went to the basic example and ran pnpx webpack serve, and it resulted in an error (probably because there is an old version of webpack-dev-server?).

Describe the solution you'd like The examples should include dependencies like webpack, webpack-cli, and webpack-dev-server, and have scripts in package.json for starting server and building. They should also work with any node version >= the minimum node version.

Describe alternatives you've considered Using the favicon option in HtmlWebpackPlugin.

Additional context I'm using nodist and pnpm on Windows 10.

Guida contributor