jaegertracing/jaeger

[test] Flaky test TestPasswordFromFile in plugin/storage/es/factory_test.go

Open

Aperta il 10 set 2023

Vedi su GitHub
 (9 commenti) (0 reazioni) (0 assegnatari)Go (18.974 star) (2326 fork)batch import
buggood first issuehelp wanted

Descrizione

https://github.com/jaegertracing/jaeger/actions/runs/6134973238/job/16648278200?pr=4742#step:7:4523

One strange thing I noticed in the output that the very last logged request to the server was with Basic Auth string looking like the first password, not the second password, as if the request with the second password was made but then someone again made a request with the old one. I wonder if the es.Client object can continue sending pings to the server if it's not Close-ed (which we don't do).

Guida contributor

Tech stack
goelasticsearch
Dominio
testingbackend
Tipo issue
test
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
active
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
GotestingElasticsearch
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
Investigate the flaky test TestPasswordFromFile in plugin/storage/es/factory test.go. Review the CI run logs linked in the issue to identify the pattern. Consider whether the es.Client is not properly closed, causing lingering connections with old credentials. Look for any related PRs or comments that discuss the issue. Attempt to reproduce the flakiness locally.