jackwener/maka-agent
refactor(cli): remove dead outcome helpers and unify MakaRunOutcome classification
Chiusa
#3088 aperta il 15 ago 2026
enhancementhelp wanted
Metriche repository
- Star
- (1 stella)
- Metriche merge PR
- (Nessuna PR mergiata in 30 g)
Descrizione
Problem
Three dead / duplicated outcome paths in packages/cli:
sandbox-boundary-failure.ts—invocationHasSandboxBoundaryFailure/invocationRecoveredSandboxBoundaryFailurehave zero callers (they are the last consumers of the removed runtime'sInvocationResult). The live siblingsessionEventSandboxBoundaryFailureReasonmust stay.MakaRunOutcomeis computed twice from two sources inruntime-host-run-command.ts— a liveTurnOutcomeAccumulator(SessionEvent stream) and a stored-message classifier (outcomeFromStoredTurn/storedSandboxBoundaryOutcome) whose vocabularies already diverge (aborted/runtime_errorvserrorClass ?? abortSource ?? status).- Dead exports with no callers:
formatResumeHint,cleanRecapText/RECAP_INSTRUCTION,runMakaTextCli,colorDiffRow.
Desired outcome
One MakaRunOutcome classifier parameterized over its source, dead helpers removed, dead exports dropped.
Alternatives or workarounds
Leave the divergence; the stored-message path already produces different failure classes from the live path.
Acceptance
-
invocationHasSandboxBoundaryFailure/invocationRecoveredSandboxBoundaryFailureremoved;sessionEventSandboxBoundaryFailureReasonretained - One outcome classifier shared by the live and stored-message paths
- Dead exports removed
-
maka runandmaka run --graphexit codes pinned by CLI tests; typecheck and Biome pass
Related
- #3034, #3035 (prior runtime path removals)